Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time strip views should only allow time-based plots, imagery and plans #5160

Closed
5 tasks
shefalijoshi opened this issue May 5, 2022 · 4 comments · Fixed by #5161
Closed
5 tasks

Time strip views should only allow time-based plots, imagery and plans #5160

shefalijoshi opened this issue May 5, 2022 · 4 comments · Fixed by #5161
Labels
severity:critical type:bug

Comments

@shefalijoshi
Copy link
Contributor

Non time based plots, other object types and layouts are currently allowed in time strip views. These should not be allowed.

Steps to Reproduce

  1. Try to add a display layout, condition set, bar graph etc to a time strip view
  2. Notice that this is allowed

Environment

  • Open MCT Version: 2.0.3
  • Deployment Type: VIPER/testathon
  • OS: Mac
  • Browser: All

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
This was referenced May 5, 2022
Merged
Merged
@shefalijoshi
Copy link
Contributor Author

Testing instructions:
Adding plots, overlay plots, stacked plots, plans, imagery should work for timestrips.
All other objects should be disallowed.

@shefalijoshi shefalijoshi self-assigned this Jun 14, 2022
@ozyx
Copy link
Contributor

ozyx commented Jun 27, 2022 •
edited
Loading

Verified -- Testathon 6/27/22

Was able to add Overlay Plot, Stacked Plot, Plan, and Example Imagery to a Timestrip.
Was not able to add Scatter Plot (non-time based) and layouts.

@charlesh88
Copy link
Contributor

Verified fixed Testathon 07-01-22.

@rukmini-bose
Copy link
Contributor

Verified Testathon 7/1/22

@unlikelyzero unlikelyzero modified the milestone: Sprint:2.0.7 Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict timestrip composition to time based plots, plans and imagery nasa/openmct
7 participants
@charlesh88 @akhenry @shefalijoshi @ozyx @jvigliotta @unlikelyzero @rukmini-bose