Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Enable lint enforcement on e2e suite #5124

Closed
unlikelyzero opened this issue Apr 27, 2022 · 2 comments · Fixed by #5141 or #5229
Closed

[e2e] Enable lint enforcement on e2e suite #5124

unlikelyzero opened this issue Apr 27, 2022 · 2 comments · Fixed by #5141 or #5229
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.5

Comments

@unlikelyzero
Copy link
Contributor

unlikelyzero commented Apr 27, 2022 •
edited
Loading

Summary

We had a breakage where .only was on a WIP PR and was merged in. We should add it to our linting rules.

Edit: @ozyx discovered that we weren't linting the tests at all! This Issue now captures that effort
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Apr 27, 2022
@unlikelyzero unlikelyzero mentioned this issue Apr 28, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Contributor Author

unlikelyzero commented May 2, 2022 •
edited
Loading

Testing Notes

Add a .only to an e2e test on a branch
Verify that npm run lint fails locally and on circleci check

@unlikelyzero unlikelyzero reopened this May 19, 2022
@unlikelyzero unlikelyzero changed the title [e2e] Prevent .only from breaking CI [e2e] Enable lint enforcement on e2e suite May 19, 2022
@ozyx ozyx self-assigned this May 19, 2022
@ozyx ozyx mentioned this issue May 19, 2022
Merged
15 tasks
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 06/27/22 - linting works for end to end tests

@unlikelyzero unlikelyzero added this to the Target:2.0.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.5
3 participants
@khalidadil @ozyx @unlikelyzero