Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace app.js with webpack-dev-server #5031

Closed
akhenry opened this issue Apr 4, 2022 · 5 comments · Fixed by #5797
Closed

Replace app.js with webpack-dev-server #5031

akhenry opened this issue Apr 4, 2022 · 5 comments · Fixed by #5797
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 4, 2022

Summary

Currently we provide app.js as a very basic web-server for development purposes. webpack-dev-server could do the same thing which would have multiple advantages:

  • Remove any ambiguity about the purpose of app.js( app.js is not an Open MCT server, and should only be used for dev purposes.)
  • Remove redundant code
  • Remove a dependency on webpack-dev-middleware
  • The security and familiarity of using an industry standard tool.
@akhenry akhenry added the type:maintenance tests, chores, or project maintenance label Apr 4, 2022
@unlikelyzero
Copy link
Contributor

@akhenry we had that filed here: #4922 to close another issue.

I'd like to demo what we'd gain by using app.js, before moving off of it

@unlikelyzero
Copy link
Contributor

@akhenry we've done quite a bit of work in the last 6 weeks on app.js. I think we should take a hard look at this.

Things to consider:

  • How are we generating sourcemaps for unit and e2e tests
  • How are we using NODE_ENV variables at build time and runtime? What associated functionality do we want between them?
  • Why do we not demonstrate how we want folks to run this?

@scottbell scottbell self-assigned this Sep 19, 2022
@scottbell scottbell linked a pull request Sep 21, 2022 that will close this issue
15 tasks
@scottbell
Copy link
Contributor

Testing Instructions:

  • Ensure npm start works for local storage
  • Ensure npm start works for CouchDB

@jvigliotta
Copy link
Contributor

Verified Fixed Locally - Tested with Local Storage and with CouchDB and there were no issues.

@akhenry
Copy link
Contributor Author

akhenry commented Oct 4, 2022

Verified fixed.

@akhenry akhenry removed the unverified label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants