Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw-loader needs to be replaced with asset modules in webpack 5 #4997

Closed
shefalijoshi opened this issue Mar 24, 2022 · 4 comments · Fixed by #4998
Closed

Raw-loader needs to be replaced with asset modules in webpack 5 #4997

shefalijoshi opened this issue Mar 24, 2022 · 4 comments · Fixed by #4998
Labels
severity:blocker type:bug
Milestone
Target:2.0.2

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Mar 24, 2022 •
edited by unlikelyzero
Loading

This seems to have broken master and needs to be reverted/fixed by using asset modules with webpack 5.

Originally posted by @shefalijoshi in #4978 (comment)

More here
https://webpack.js.org/guides/asset-modules/
@scottbell scottbell linked a pull request Mar 25, 2022 that will close this issue
remove raw-loader as a dependency #4998
Merged
15 tasks
@scottbell
Copy link
Contributor

To test:

  • Create a Sin Wave Generator
  • View plot
  • Ensure it loads and the console doesn't show: Uncaught SyntaxError: Unexpected identifier

@scottbell scottbell mentioned this issue Mar 25, 2022
Merged
15 tasks
@shefalijoshi
Copy link
Contributor Author

@davetsay https://github.com/nasa/openmct/pull/4998/files#r835370706

@unlikelyzero unlikelyzero assigned davetsay and unassigned scottbell and davetsay Apr 4, 2022
@unlikelyzero
Copy link
Contributor

Verified by Shefali

@michaelrogers
Copy link
Contributor

Fix verified in testathon on 2022-04-04.

@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:blocker type:bug
Projects
None yet
Milestone
Target:2.0.2
Development

Successfully merging a pull request may close this issue.

remove raw-loader as a dependency nasa/openmct
5 participants
@davetsay @shefalijoshi @michaelrogers @scottbell @unlikelyzero