Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notebook] Dropped item embeds not displaying properly #4967

Closed
3 of 5 tasks
jvigliotta opened this issue Mar 22, 2022 · 5 comments · Fixed by #5791
Closed
3 of 5 tasks

[Notebook] Dropped item embeds not displaying properly #4967

jvigliotta opened this issue Mar 22, 2022 · 5 comments · Fixed by #5791
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Milestone

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Mar 22, 2022

Summary

Dropping an item into a notebook results in an improperly formatted embed. Snapshot embeds are fine.

Expected vs Current Behavior

Should show up like in the image below, with an icon and a link.

Steps to Reproduce

  1. Drop an item into a notebook

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information

Screen Shot 2022-03-22 at 11 07 36 AM

@unlikelyzero
Copy link
Contributor

Needs a Visual Test

  1. Create Notebook
  2. Create Overlay Plot
  3. Drop Overlay Plot into Notebook
  4. percysnapshot()

@unlikelyzero unlikelyzero added the help_wanted Help the Open MCT project! label May 4, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@charlesh88
Copy link
Contributor

Workaround here is to use Snapshots, but we should fix this if not too risky.

@jvigliotta
Copy link
Contributor Author

Testing

  • Drop an object into the "drop area" of a notebook (see image below)
  • Verify that the name and icon show up correctly (previously, no icon and no name were showing)

@jvigliotta jvigliotta added Target:2.1.1 unverified and removed Target:2.0.6 help_wanted Help the Open MCT project! needs:e2e Needs an e2e test labels Sep 20, 2022
@rukmini-bose
Copy link
Contributor

Verified Testathon 9/30

@ozyx
Copy link
Contributor

ozyx commented Sep 30, 2022

Verified fixed -- Testathon 09/30/22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants