Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align image freshness indicators with VERVE #4885

Closed
akhenry opened this issue Feb 21, 2022 · 7 comments · Fixed by #5002
Closed

Align image freshness indicators with VERVE #4885

akhenry opened this issue Feb 21, 2022 · 7 comments · Fixed by #5002

Comments

@akhenry
Copy link
Contributor

akhenry commented Feb 21, 2022

Is your feature request related to a problem? Please describe.
Image freshness indicators in Open MCT last too long, and blinking is too obnoxious.

Describe the solution you'd like

  • Default timing of freshness indicators and should be aligned with VERVE.
  • Fade out approach used in VERVE should be considered instead of blinking.
@michaelrogers
Copy link
Contributor

michaelrogers commented Mar 28, 2022

Testing Instructions

Observe that the Imagery view freshness indicator no longer blinks but fades out once sufficiently ripe. In the default configuration, the fade should take 30 seconds from initial freshness indication.

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Apr 25, 2022

Not fixed. While the image freshness indicator does fade out, it also fades back in.

@charlesh88
Copy link
Contributor

Verified NOT fixed Testathon 04-25-22:

Screen Shot 2022-04-25 at 3 10 39 PM

  1. Clicking a past image, then clicking the Play button to resume real-time causes the freshness indicator to reapply, but shouldn't.
  2. Camera and Position freshness buttons have lost their color styling.

@michaelrogers
Copy link
Contributor

michaelrogers commented Apr 26, 2022

@charlesh88 - Excellent finds. I have a pr that attempts to address some of these issues. #5116

  1. Currently the isNewImage is set to an arbitrary threshold of 5 minutes. In the linked PR, I adjusted the cutoff to be less than the animation duration+delay length. I suspect this may not address the core of the issue, this would prevent the animation from retriggering if it were over the animation threshold. Prior to any changes, any selected image (doesn't have to be most recent) will be marked as fresh if still under the isNewImage threshold.
  2. Do camera & position freshness need separate animation values or can they reuse the image freshness indicators values? In the attached PR I have simply reused them, but they could be separate values if desired.

@akhenry
Copy link
Contributor Author

akhenry commented Apr 28, 2022

Per discussion 04/28 positional and camera freshness indicators should never time out.

@akhenry akhenry closed this as completed Apr 28, 2022
@charlesh88
Copy link
Contributor

Verified fixed Testathon 4/28/22

@akhenry
Copy link
Contributor Author

akhenry commented Apr 28, 2022

Verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants