Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Enforce node version at build-time #4845

Closed
unlikelyzero opened this issue Feb 9, 2022 · 3 comments · Fixed by #4846
Closed

[Build] Enforce node version at build-time #4845

unlikelyzero opened this issue Feb 9, 2022 · 3 comments · Fixed by #4846
Assignees
@khalidadil
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.5

Comments

@unlikelyzero
Copy link
Contributor

Summary

We have an impossible number of warnings thrown at build time due to dependencies out of our control. This means that it's easy to overlook our engine enforcement -- in some cases it's not even visible due to standard out windowsizes!

NPM provides a configuration to make engine enforcement more concrete with the .npmrc file
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Feb 9, 2022
@unlikelyzero unlikelyzero mentioned this issue Feb 9, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Contributor Author

Testing Notes

Use a node version of 10 or 16. Attempt to install with npm install
Reference openmct in a another project which builds from source: viper-openmct, VISTA?

@unlikelyzero unlikelyzero added this to the Target: 1.8.5 milestone Feb 14, 2022
@khalidadil
Copy link
Contributor

@unlikelyzero Can you please provide more detailed testing notes here? I'm not clear on what I should be seeing to verify this is working.

@khalidadil
Copy link
Contributor

khalidadil commented Feb 14, 2022 •
edited
Loading

I tested this with node 16 and got this error, so looks good to me! Testathon on 02/14/2022

npm ERR! engine Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"node":">=12.20.1 <15.0.0"}```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khalidadil khalidadil

Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.5
Development

Successfully merging a pull request may close this issue.

[Build] Enforce engine at build time nasa/openmct
3 participants
@khalidadil @shefalijoshi @unlikelyzero