Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelist view for activities within a plan #4765

Closed
shefalijoshi opened this issue Jan 21, 2022 · 7 comments · Fixed by #4766 or #5300
Closed

Timelist view for activities within a plan #4765

shefalijoshi opened this issue Jan 21, 2022 · 7 comments · Fixed by #4766 or #5300
Labels

Comments

@shefalijoshi
Copy link
Contributor

Create new object type and view that lists past, current and future activities within a plan
Each activity should have:
name
start time
end time
duration to/from current time

The list should be sortable by start time.
The list should have some current activities in view at all times.

Display of past, current and future activities should be configurable.

@shefalijoshi
Copy link
Contributor Author

Testing instructions:
Create a timelist object
Ensure a list of activities is displayed
Use the Filtering options in the inspector to change the list.

@akhenry
Copy link
Contributor

akhenry commented Apr 28, 2022

Not verified. The current implementation of the time list view requires you to upload a plan file. This needs to be addressed.

@charlesh88
Copy link
Contributor

Testathon 4-28-22: agree with Andrew, we missed this. A plan file should not be required when creating or editing a Time List view.

@shefalijoshi
Copy link
Contributor Author

Testing Instructions:

  1. Ensure that a Timelist object can be created without specifying a plan file
  2. After creation ensure that only 1 plan can be used in the Timelist composition at a given time (drag and drop a plan)
  3. If you drag and drop a plan into the Timelist when it already has a plan, it should show a dialog to replace the current plan.

@shefalijoshi shefalijoshi removed the needs:test instructions Missing testing notes label Jun 9, 2022
@rukmini-bose
Copy link
Contributor

Verified Testathon 06/09/2022

@michaelrogers
Copy link
Contributor

michaelrogers commented Jun 9, 2022

Screen Shot 2022-06-09 at 5 09 08 PM
Seeing a toLowerCase error when dragging a new plan into a timelist object. I have an old plan json object that might be the cause. I properly received the modal notifying I would replace the plan if dragging a different plan.

Think this is just a tester bug, using existing plans this works as expected.

@charlesh88
Copy link
Contributor

I can't dupe @michaelrogers problem as described; a new Timelist using a Plan from VIPER Plans works as expected.
Verified fixed Testathon 6-9-22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants