Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enable more e2e tests as a part of our CI Checks #4674

Closed
unlikelyzero opened this issue Jan 5, 2022 · 2 comments · Fixed by #4672
Closed

[CI] Enable more e2e tests as a part of our CI Checks #4674

unlikelyzero opened this issue Jan 5, 2022 · 2 comments · Fixed by #4672
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.4

Comments

@unlikelyzero
Copy link
Contributor

unlikelyzero commented Jan 5, 2022 •
edited
Loading

Summary

We had a regression in basic functionality in recent changes. #4666 We had an e2e written but not run. This PR enables more e2e tests in the npm 'test:e2e:ci' script which is run on each commit.

We will make sure that we only select new tests to keep the runtime to 5 minutes or less (or the pizza's free!)

Part of this PR will ensure that we only run 2 workers per Agent.

Screen Shot 2022-01-05 at 8 49 24 AM
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jan 5, 2022
This was referenced Jan 5, 2022
Closed
Merged
@unlikelyzero
Copy link
Contributor Author

Testing Notes

Verify that at least 2 suites of tests are running as a part of each PR check.
Verify that CPU utilization doesn't peg at 100% during the course of execution on the circleci/resources tab

@unlikelyzero unlikelyzero added this to the Target: 1.8.4 milestone Jan 5, 2022
@unlikelyzero unlikelyzero linked a pull request Jan 5, 2022 that will close this issue
Unable to create domain objects #4672
Merged
8 tasks
@shefalijoshi
Copy link
Contributor

Verified fixed

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.4
Development

Successfully merging a pull request may close this issue.

Unable to create domain objects
Run more e2e tests on PR nasa/openmct
3 participants
@shefalijoshi @jvigliotta @unlikelyzero