Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Modify the dependabot config to pick up packages which contain the dependency name instead of startwith #4642

Closed
unlikelyzero opened this issue Dec 30, 2021 · 2 comments · Fixed by #4635
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@unlikelyzero
Copy link
Contributor

Summary

The current dependabot config will only trigger on packages which start with the specified package name. We should modify the file so that any package which contains the keywords are detected.

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 30, 2021
@unlikelyzero
Copy link
Contributor Author

Testing Notes

Verify that since this PR was merged, at least one PR was created by dependabot to run against a package which contains (but does not start with) the list of packages here

- dependency-name: "eslint*"
- dependency-name: "karma*"
- dependency-name: "jasmine*"
- dependency-name: "playwright*"
- dependency-name: "percy*"

@unlikelyzero
Copy link
Contributor Author

Cannot find a good example to verify. I'm going to rip off this whitelist bandaid next sprint so I'll just leave this one dangling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant