Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update Readme to include badge from npm registry #4618

Closed
unlikelyzero opened this issue Dec 21, 2021 · 6 comments · Fixed by #4619
Closed

[Doc] Update Readme to include badge from npm registry #4618

unlikelyzero opened this issue Dec 21, 2021 · 6 comments · Fixed by #4619
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.4

Comments

@unlikelyzero
Copy link
Contributor

Summary

It's possible to add a badge for the npm registry directly on the readme.
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 21, 2021
@unlikelyzero unlikelyzero mentioned this issue Dec 21, 2021
Merged
8 tasks
@depperm
Copy link
Contributor

depperm commented Dec 22, 2021 •
edited
Loading

What badges for npm do you want exactly? Just npm (t)? Or ones for jasmine and karma?

@unlikelyzero
Copy link
Contributor Author

@depperm just npm as a link to npm. There's a PR for it here #4619

@unlikelyzero
Copy link
Contributor Author

Testing Notes

Verify that the npm link appears on the root of the github page.
Verify that when clicking on the link, the browser navigates to the npm package on npmjs.org
Verify that the release version is correct

@akhenry
Copy link
Contributor

akhenry commented Jan 24, 2022

Verified fixed!

@charlesh88
Copy link
Contributor

Testathon 1-24-22: verified fixed.

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@unlikelyzero unlikelyzero added this to the Target: 1.8.4 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.4
Development

Successfully merging a pull request may close this issue.

Add npm badge for the lazy nasa/openmct
5 participants
@charlesh88 @nikhilmandlik @akhenry @depperm @unlikelyzero