Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement LocalStorage in ES6 and without Angular #4589

Closed
akhenry opened this issue Dec 15, 2021 · 3 comments · Fixed by #4583
Closed

Re-implement LocalStorage in ES6 and without Angular #4589

akhenry opened this issue Dec 15, 2021 · 3 comments · Fixed by #4583
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.3

Comments

@akhenry
Copy link
Contributor

akhenry commented Dec 15, 2021

Summary

The LocalStorage adapter is currently implemented using prototypical object inheritence and should be re-implemented using ES6 Classes using our modern API.
@akhenry akhenry added the type:maintenance tests, chores, or project maintenance label Dec 15, 2021
@akhenry akhenry self-assigned this Dec 15, 2021
This was referenced Dec 15, 2021
Closed
Merged
@akhenry
Copy link
Contributor Author

akhenry commented Dec 16, 2021 •
edited
Loading

Tasting Notes 🍷

This is a re-implementation of the Local Storage adapter, so it will need to be tested locally.

  • Verify that objects already defined in your local storage appear in the tree
  • Verify that new objects can be created successfully
  • Verify that existing objects can be edited and saved successfully, and that any changes are persisted.

@unlikelyzero unlikelyzero added this to the Target: 1.8.3 milestone Jan 3, 2022
@charlesh88
Copy link
Contributor

Testathon 01-04-22: cannot verify - existing objects can be removed and modified, but new objects cannot be created due to another issue.

@unlikelyzero unlikelyzero reopened this Jan 4, 2022
@unlikelyzero unlikelyzero assigned charlesh88 and unassigned charlesh88 Jan 6, 2022
@charlesh88
Copy link
Contributor

Verified fixed Testathon 01-06-22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.3
Development

Successfully merging a pull request may close this issue.

Rewrite local storage nasa/openmct
4 participants
@charlesh88 @akhenry @shefalijoshi @unlikelyzero