Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imagery] Adjusting the bounds will sometimes cause the focusedImage to shift which image is selected #4555

Closed
3 of 5 tasks
michaelrogers opened this issue Dec 8, 2021 · 2 comments · Fixed by #4689
Closed
3 of 5 tasks

Comments

@michaelrogers
Copy link
Contributor

michaelrogers commented Dec 8, 2021

Summary

Seems to be limited in scope to local clock; the fixed timespan flow seems to be working as expected.

Expected vs Current Behavior

If the index is properly matched in the updated imageHistory array, the index should be maintained and the image should not be replaced.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Navigate to example imagery
  2. Adjust the time bounds of local clock
  3. Observe sometimes the image will change

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Additional Information

@michaelrogers michaelrogers changed the title Imagery - Adjusting the bounds will sometimes cause the focusedImage to shift which image is selected [Imagery] Adjusting the bounds will sometimes cause the focusedImage to shift which image is selected Dec 8, 2021
@michaelrogers michaelrogers self-assigned this Dec 9, 2021
@unlikelyzero unlikelyzero added this to the Target: 1.8.3 milestone Jan 6, 2022
@unlikelyzero unlikelyzero linked a pull request Jan 7, 2022 that will close this issue
8 tasks
@unlikelyzero unlikelyzero mentioned this issue Jan 7, 2022
8 tasks
@unlikelyzero unlikelyzero added the needs:test instructions Missing testing notes label Jan 7, 2022
@michaelrogers
Copy link
Contributor Author

michaelrogers commented Jan 7, 2022

How to Test

For Fixed Time

  • Navigate to an existing Image Telemetry item
  • Set to Fixed Time if not already selected
  • Select an image thumbnail to focus on in the time strip
  • Adjust the upper or lower bounds of the date picker; e.g. select a date further in the future
  • Observe that if the image still exists in the range, that it does not change
  • Or observe that if the image is no longer in range, the last image is selected

For Local Time

  • Navigate to an existing Image Telemetry item
  • Set to Local Time if not already selected
  • Select an image thumbnail to focus on in the time strip
  • Adjust the upper or lower bounds of the relative time picker; e.g. increase the upper bounds by 5 minutes
  • Observe that if the image still exists in the range, that it does not change
  • Or observe that if the image is no longer in range, the last image is selected

@michaelrogers michaelrogers removed the needs:test instructions Missing testing notes label Jan 7, 2022
@jvigliotta
Copy link
Contributor

Nice work!
Testathon - 1.7.22 - Verified Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants