-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Telemetry Request Abort #4361
Comments
I would like to see this implemented in the API if possible, so that we don't have to put a lot of boilerplate in individual views. On navigation the telemetry API could automatically abort the request and reject the promise. That way, our views would only need to handle rejected promises (which they should anyway) and would not need specific handling for handling abort. The Telemetry API would just need to manage an AbortController and pass it down to the telemetry providers along with the passed in arguments. We will need to modify the telemetry provider interface slightly to include an optional abort controller. We should make sure that the public documentation gets updated when we do this. To detect navigation the telemetry API could listen to the ApplicationRouter's |
Testing instructions:
|
Verified Fixed - Testathon: 12/13/2021 Any existing telemetry requests were canceled. |
Verified fixed - testathon 12/13/2021 |
Verified Fixed. |
Is your feature request related to a problem? Please describe.
Clicking multiple views in succession will continue to queue up requests, even if the view has been destroyed and the requests are not needed anymore. If enough requests are queued up the UI becomes unusable.
Describe the solution you'd like
Implement abort in views
Additional context
There should be partial implementation already.
VISTA ticket: https://github.jpl.nasa.gov/MissionControl/vista/issues/964
The text was updated successfully, but these errors were encountered: