Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "My Items" plugin needed #4088

Closed
akhenry opened this issue Aug 5, 2021 · 2 comments · Fixed by #4107 or #4471
Closed

New "My Items" plugin needed #4088

akhenry opened this issue Aug 5, 2021 · 2 comments · Fixed by #4107 or #4471

Comments

@akhenry
Copy link
Contributor

akhenry commented Aug 5, 2021

Is your feature request related to a problem? Please describe.
The "my items" object currently depends on a mixture of code that is split between the legacy and current APIs. The legacy code should be replaced, and the code consolidated into a new "My Items" plugin.

Describe the solution you'd like
The legacy "My Items" bundle should be removed, and replaced with a "My Items" plugin (Under src/plugins/MyItems). The legacy My Items bundle did two things, one of which has already been replaced with new code:

  1. It creates a "My Items" root object. This can be replaced with a call to openmct.objects.addRoot('mine')
  2. It creates a "My Items" model. This has already been replaced by an "Object Interceptor" that does the same thing using the current API, however the interceptor code should be moved into the new "My Items" plugin.

The new My Items plugin will need to be exposed on the openmct API object so that it can be easily installed.

@jvigliotta
Copy link
Contributor

jvigliotta commented Aug 10, 2021

Testing

  • verify "My Items" folder is showing up correctly
  • if possible, delete "My Items" (DO NOT DELETE on Banner \ try on local couchDb) from the DB or start a new instance of Open MCT where "My Items" is not in the DB and verify it does show up

@nikhilmandlik
Copy link
Contributor

Tested locally with coucdb, after deleting mine from couchdb on UI my items shows up but there is no corresponding document in couchdb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants