Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linting] Fix Lint Errors (will be required for merge) #4081

Closed
5 tasks
jvigliotta opened this issue Aug 4, 2021 · 1 comment · Fixed by #4082
Closed
5 tasks

[Linting] Fix Lint Errors (will be required for merge) #4081

jvigliotta opened this issue Aug 4, 2021 · 1 comment · Fixed by #4082
Assignees
Labels
type:bug type:maintenance tests, chores, or project maintenance

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Aug 4, 2021

Summary

We have 3 lint errors that need to be addressed before #4078 completed.

src/plugins/persistence/couch/CouchObjectProvider.js
50:66  error  '__OPENMCT_ROOT_RELATIVE__' is not defined  no-undef
src/plugins/remoteClock/RemoteClockSpec.js
140:93  error  Object properties must go on a new line  object-property-newline
src/plugins/remoteClock/plugin.js
25:64  error  Trailing spaces not allowed  no-trailing-spaces

Expected vs Current Behavior

No linting errors

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Run npm lint at project root (for testing, confirm no errors, warnings ok for now)
@unlikelyzero
Copy link
Contributor

unlikelyzero commented Aug 26, 2021

Testathon 08/26 Warnings persist but no linting errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants