Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Painterro] Painterro text input not being removed after annotating Snapshot #4019

Closed
charlesh88 opened this issue Jul 13, 2021 · 4 comments
Closed

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jul 13, 2021

Seen on /stable 1.7.5 and current master running locally.

Reproduce

  1. Create a new Snapshot, click it and get to the annotation interface.
  2. Add a text element:

Annotation Open MCT

  1. Save the annotation and exit the Snapshot overlay dialog. Note at the very bottom of the tree on the left you'll see a pink dotted line:

image

  1. Dragging on the browser's bottom edge to Increase the height of the window will reveal the annotation's text element:

image

  1. Looking in Dev Tools > Elements, you'll see that contenteditable divs are being left in the DOM:

Painterro text leftovers

Multiple rounds of annotation leave multiple contenteditables remaining; refreshing clears them. Although the above screenshot shows a count of two console errors, they aren't being created by this problem.

@nikhilmandlik
Copy link
Contributor

created issue for painterro, devforth/painterro#150

@nikhilmandlik
Copy link
Contributor

They have fixed this issue in new version v1.2.58

@unlikelyzero
Copy link
Contributor

@nikhilmandlik to verify before thursday

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants