Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Classic height calculation needs to handle Snapshot container expansion and collapse #3929

Closed
charlesh88 opened this issue Jun 7, 2021 · 4 comments · Fixed by #4132
Closed

Comments

@charlesh88
Copy link
Contributor

The tree scroll area is not handling the Snapshot area being expanded and collapsed in its vertical space calculation, but should.

Steps to replicate

  1. Close the Snapshots container via its Status Area icon, if expanded.
  2. Expand the tree and/or resize the browser window such that the tree has a vertical scroll, like this:
    Screen Shot 2021-06-07 at 3 57 56 PM
  3. Expand the Snapshots container, then observe that the tree clips items at the bottom of the scrolling area, and the scroll height hasn't been recalculated. It's now not possible to scroll any farther to get to the clipped items:
    Screen Shot 2021-06-07 at 3 58 10 PM
  4. With the Snapshots container visible, resize the browser window a bit, which forces the tree scrolling area height to be recalculated. The clipped items will now be scrollable to.
  5. Now, close the Snapshots container and observe: the tree height doesn't recalculate and is now too short:
    Screen Shot 2021-06-07 at 3 57 10 PM
@unlikelyzero unlikelyzero added bug:visual Visual problem. Not a functional issue severity:medium and removed bug:visual Visual problem. Not a functional issue labels Jun 8, 2021
@unlikelyzero
Copy link
Contributor

@nikhilmandlik to retest

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@kobe1104
Copy link
Contributor

Verified fixed - testathon 8/26/2021

@charlesh88
Copy link
Contributor Author

Testathon 8-26-21: verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants