Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI "typos" #3909

Closed
8 tasks done
charlesh88 opened this issue Jun 2, 2021 · 4 comments · Fixed by #3984
Closed
8 tasks done

Fix UI "typos" #3909

charlesh88 opened this issue Jun 2, 2021 · 4 comments · Fixed by #3984

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jun 2, 2021

Fix various "typos" in the UI:

  • Snapshots erroneous character:
    Screen Shot 2021-06-02 at 10 51 03 AM
  • Snapshot annotation interface layout is whacked, and...
  • Snapshot dialog template has bad spacing between icon and name, and...
  • Snapshot annotation interface Cancel and Save buttons are the reverse of what they should be:
    image
  • Double icon in Display Layouts Inspector:
    Screen Shot 2021-06-02 at 10 51 08 AM
  • Stop menu item doesn't indent properly:
    Screen Shot 2021-06-02 at 11 08 04 AM
  • Tree items need margin right:

Screen Shot 2021-06-02 at 11 26 14 AM

  • Time Conductor RT input looks visually blown out in Snow theme; probably a filter setting.
    Screen Shot 2021-06-07 at 11 41 27 AM
@charlesh88
Copy link
Contributor Author

charlesh88 commented Jun 7, 2021

Testing Notes

  1. Expand the Notebook Snapshots container, then take a new Snapshot and save it to 'Notebook Snapshots'. Verify that the header element looks similar to this and that there are no weird characters as shown in the original issue screenshot:

image
2. Edit or create a Display Layout. Add a drawing object (box, line, or text field) and click to select it. Verify that the Inspector title looks like the element indicated by the orange arrow and is not displaying a double icon as shown in the issue :

Screen Shot 2021-06-07 at 3 59 06 PM
3. Take a Snapshot of anything. Click the Snapshot thumbnail to view the Snapshot overlay, and verify that the spacing between the icon and name in the title looks Ok, as in the following:

Screen Shot 2021-06-24 at 5 17 25 PM

4. While in the Snapshot dialog, click the Annotate button. Verify that the toolbar looks like the following image, and not as shown in the bug report above. Also, verify that "Save" is hilited, and "Cancel" is gray, in the lower right of the dialog

Screen Shot 2021-06-24 at 5 01 52 PM

  1. Verify that the Stop menu item in the Timer context menu has an icon and is properly indented:

image

  1. Verify that the tree items have a bit of margin on the right side when the scroll bar is displayed:

image

  1. Verify that the RT Time Conductor popup in the Snow theme looks correct:

image

@charlesh88
Copy link
Contributor Author

charlesh88 commented Jul 12, 2021

Verified fixed Testathon 07-12-21. Issue seen with Painterro custom checkboxes, new issue filed with #4011

@davetsay
Copy link
Contributor

verified...

but ran into unreplicatable snapshot bug #4012

@nikhilmandlik
Copy link
Contributor

Verified Fixed. other than font issue @charlesh88 mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants