Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Abort Search] Still makes requests after abort #3727

Closed
jvigliotta opened this issue Mar 3, 2021 · 0 comments · Fixed by #3728
Closed

[Abort Search] Still makes requests after abort #3727

jvigliotta opened this issue Mar 3, 2021 · 0 comments · Fixed by #3728

Comments

@jvigliotta
Copy link
Contributor

Some cases have shown more requests being made after aborting search, due to getOriginalPath being called in aggregateSearchResults. Need to cancel that as well.

Testing

  • same as regular abort search testing
  • search with couchDB setup
  • cancel search and make sure no more requests are made in the network tab
  • search and wait a second or two or three or four, your choice really, then cancel and make sure all reqs stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Abort Search] Completely Abort Search nasa/openmct
2 participants
@shefalijoshi @jvigliotta