Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor plots to use Vue #3691

Closed
shefalijoshi opened this issue Feb 19, 2021 · 5 comments · Fixed by #3586
Closed

Refactor plots to use Vue #3691

shefalijoshi opened this issue Feb 19, 2021 · 5 comments · Fixed by #3586

Comments

@shefalijoshi
Copy link
Contributor

Plots for telemetry objects, overlay plots and stacked plots should be implemented using Vue and no longer use Angular
@shefalijoshi shefalijoshi self-assigned this Feb 19, 2021
@shefalijoshi shefalijoshi mentioned this issue Feb 19, 2021
Merged
@charlesh88
Copy link
Contributor

How is this to be tested?

@akhenry
Copy link
Contributor

akhenry commented Feb 25, 2021

@shefalijoshi Testing instructions

@shefalijoshi
Copy link
Contributor Author

shefalijoshi commented Mar 3, 2021 •
edited
Loading

Testing instructions:

  1. Create a time strip from the Create menu.
  2. Drag in a telemetry endpoint, a stacked plot and an overlay plot into the time strip
  3. Check for the following:
  • The 3 plots are rendered in the time strip view
  • None of the plots show the X Axis
  • The toolbar to export images as PNG, JPG are hidden
  • Zoom, pan, reset still works
  • Change the time bounds and ensure the data in the plots refreshes correctly

@charlesh88
Copy link
Contributor

Verified fixed Testathon 3-3-21-EB.

@akhenry
Copy link
Contributor

akhenry commented Mar 4, 2021

Verified fixed

@akhenry akhenry removed the unverified label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plots refactor to use Vue and es6 instead of angular nasa/openmct
3 participants
@charlesh88 @akhenry @shefalijoshi