Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs View] Improve Lazy Load logic #3672

Closed
deeptailor opened this issue Feb 8, 2021 · 0 comments · Fixed by #3671
Closed

[Tabs View] Improve Lazy Load logic #3672

deeptailor opened this issue Feb 8, 2021 · 0 comments · Fixed by #3671

Comments

@deeptailor
Copy link
Contributor

At the moment, when using the lazy load option, we destroy the tabs when the user clicks away from the current tab.

We should keep already loaded tabs active but use visibility hidden to hide it from users view, this will greatly improve load times, and allows users to switch back and forth like tabs view was designed to.

Testing Notes

  1. Create a dense layout with multiple plots and tables
  2. Create a stacked plot with 3 to 4 plots.
  3. Create a tabs view and set the eager load option to false.
  4. Add the 2 views created earlier into the tabs view.
  5. Refresh the page.
  6. Click on the other tab, notice that the new tab will load when you click on it.
  7. Click on the first tab, notice that the first tab will already be loaded when you click on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants