Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tree Item] Clicking on tree item when in edit mode is broken #3667

Closed
deeptailor opened this issue Feb 5, 2021 · 3 comments · Fixed by #3668
Closed

[Tree Item] Clicking on tree item when in edit mode is broken #3667

deeptailor opened this issue Feb 5, 2021 · 3 comments · Fixed by #3668
Labels
severity:critical

Comments

@deeptailor
Copy link
Contributor

Clicking on the tree item when in edit mode triggers preview and navigate, when it should only trigger preview.

Steps to reproduce:

  1. Navigate to an editable domainObject.
  2. Click on the edit button
  3. When in edit mode, click on another domainObject in the tree
  4. This should invoke a preview of the domainObject, just as expected.
  5. Close the overlay.
  6. Oh no, you were also navigated to the item you were previewing 👎
@deeptailor deeptailor mentioned this issue Feb 5, 2021
Merged
@tiffanyatruong
Copy link

verified fixed 2/25/21

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 2/25/2021

@charlesh88
Copy link
Contributor

Verified fixed Testathon 02/25/21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Preview when in edit mode nasa/openmct
5 participants
@charlesh88 @akhenry @jvigliotta @deeptailor @tiffanyatruong