Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Collections] Add new Telemetry API endpoint for aggregated time-bound telemetry #3639

Closed
jvigliotta opened this issue Jan 11, 2021 · 5 comments · Fixed by #3689
Closed
Assignees

Comments

@jvigliotta
Copy link
Contributor

  • Add new function to Telemetry API that returns a telemetryCollection
    • Telemetry Collection works similarly to BoundedTableRowCollection, but is generalized
    • Manages telemetry data and ensures all data is within bounds
    • Keeps telemetry sorted by timestamp
    • Exposes event for when telemetry is added (happens on page, historical request, subscription)
    • Exposes event for when telemetry is removed (happens when telemetry falls out of time bounds)
  • TelemetryCollection will essentially remove the distinction between historical and realtime data from views
  • TelemetryCollection will expose method for requesting next page, and allowing view to determine if more pages available.
  • Telemetry providers will hide details of how paging works in their particular case (different backends will implement paging differently)
  • Telemetry API and telemetry providers ARE SINGLETONS AND SHOULD NOT STORE STATE.
@akhenry
Copy link
Contributor

akhenry commented Aug 10, 2021

Created followup issue for deferred paging work - #4104

@akhenry
Copy link
Contributor

akhenry commented Aug 10, 2021

Created followup issue for additional tests - #4105

@jvigliotta
Copy link
Contributor Author

Currently enabled for Telemetry Tables

Testing

  • View a Telemetry Table
  • Verify the following are working as expected:
  • Add/Remove Telemetry
  • Switch between realtime/historical
  • Pause telemetry
  • Filter telemetry columns
  • Hide/Show columns
  • Do various mixes of all of the above

@charlesh88
Copy link
Contributor

Testathon 8-26-21: verified with all tests as noted.

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants