Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] objectEventEmitter.js is not used #3625

Closed
davetsay opened this issue Dec 30, 2020 · 3 comments
Closed

[Maintenance] objectEventEmitter.js is not used #3625

davetsay opened this issue Dec 30, 2020 · 3 comments
Assignees
@davetsay
Labels
type:maintenance tests, chores, or project maintenance

Comments

@davetsay
Copy link
Contributor

davetsay commented Dec 30, 2020 •
edited
Loading

Overview

objectEventEmitter.js is not used anywhere.

Expected Behavior

No adverse effects or regressions as a result of removing dead code.

Steps to Reproduce

  1. grep for objecteventemitter in codebase
  2. Verify nothing in object api breaks as a result of removed code. Notably, any events not being communicated between instances of the same object.
@davetsay
Copy link
Contributor Author

@akhenry , @deeptailor , I don't think objectEventEmitter.js is ever used. I can remove it if you agree. I believe it should have been removed in a5a17b9.

@deeptailor
Copy link
Contributor

@davetsay - Agree, it must have been left over after the refactor

@davetsay davetsay mentioned this issue Jan 11, 2021
Merged
@davetsay davetsay self-assigned this Jan 11, 2021
@davetsay davetsay added the type:maintenance tests, chores, or project maintenance label Jan 11, 2021
@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 2/25/2021

Couldn't find any hits in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davetsay davetsay

Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davetsay @akhenry @jvigliotta @deeptailor