Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlay Plot] Should not accept Imagery on Drop #3599

Closed
jvigliotta opened this issue Dec 14, 2020 · 7 comments
Closed

[Overlay Plot] Should not accept Imagery on Drop #3599

jvigliotta opened this issue Dec 14, 2020 · 7 comments
Labels
bug:regression It used to work. Now it doesn't :( severity:medium type:bug

Comments

@jvigliotta
Copy link
Contributor

Currently you can drag and drop example imagery in to an overlay plot.

Steps to Reproduce

  • create overlay plot
  • create example imagery
  • drag example imagery into overlay plot
  • observe nothing shows up, but the example imagery is in the composition and inspector view
  • errors for 'unit' are also being thrown
@deeptailor deeptailor added type:bug bug:regression It used to work. Now it doesn't :( medium-priority labels Dec 14, 2020
@jvigliotta jvigliotta changed the title [Overlay Plot] Should not accept Imagery on [Overlay Plot] Should not accept Imagery on Drop Dec 14, 2020
@deeptailor
Copy link
Contributor

This seems to be a regression, maybe with the type def of imagery

@akhenry
Copy link
Contributor

akhenry commented Oct 1, 2021

@michaelrogers I would first check that this is reproducible and then let's talk about next steps.

Might need a tweak to the plot's "composition policy".

@michaelrogers
Copy link
Contributor

@akhenry - I am not able to immediately reproduce this issue. I'm double checking my overlay plot configuration and attempting a few edge cases but I did not see evidence of the image being added to the composition when I inspected the exported JSON of the plot.

@michaelrogers
Copy link
Contributor

@akhenry - What is the correct process for closing an issue that seems to have been resolved previously. Should I close and mark with the Unverified tag?

@akhenry
Copy link
Contributor

akhenry commented Oct 6, 2021

@michaelrogers Ah! yes, close it and add an unverified label. That way it will get picked up in the next round of testing. Once it's confirmed fixed by testing, we will remove the unverified label.

@kobe1104
Copy link
Contributor

kobe1104 commented Oct 8, 2021

Verified fixed. Testathon 10/8/2021

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( severity:medium type:bug
Projects
None yet
Development

No branches or pull requests

7 participants