Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Requests] Improved Time Conductor inputs #3311

Closed
jvigliotta opened this issue Aug 20, 2020 · 6 comments
Closed

[User Requests] Improved Time Conductor inputs #3311

jvigliotta opened this issue Aug 20, 2020 · 6 comments

Comments

@jvigliotta
Copy link
Contributor

Provide the user with a more intuitive way to input time for the time conductor.

@jvigliotta jvigliotta self-assigned this Aug 20, 2020
@charlesh88 charlesh88 self-assigned this Dec 3, 2020
@charlesh88
Copy link
Contributor

charlesh88 commented Dec 3, 2020

Todos @jvigliotta:

  • Implement Enter key to apply values and dismiss bubble; make Esc cancel. [UT-OCT20-02]
  • Handle clicks outside the input bubble: implement an outside click handler that cancels input and dismisses the input. [UT-OCT20-08]

Todos @charlesh88

  • Change current range settings from inputs to clickable-looking elements [UT-OCT20-01]
  • Try removing leading 00's from inputs, just use numbers AND/OR try adding zero padding on keydown, with zero padding grayed down. [UT-OCT20-12]
  • Include valid entry ranges in tooltips on inputs [UT-OCT20-14]

@charlesh88 charlesh88 changed the title [User Requests] Design for improved time conductor inputs [User Requests] Design for improved Time conductor inputs Dec 3, 2020
@charlesh88 charlesh88 changed the title [User Requests] Design for improved Time conductor inputs [User Requests] Improved Time Conductor inputs Dec 3, 2020
@jvigliotta
Copy link
Contributor Author

@charlesh88 added these features

@charlesh88
Copy link
Contributor

Testing Notes

  1. Navigate to a plot view or layout that includes time-based telemetry.
  2. Set the Time Conductor to Local UTC to enable real-time mode.
  3. Ensure that the conductor looks like this:
    Screen Shot 2021-01-26 at 3 17 24 PM
  4. Click the Start time button, and verify that a popup interface is displayed:
    Screen Shot 2021-01-26 at 3 17 41 PM
  5. Verify that that the "HRS" field's value is pre-selected.
  6. Verify that tooltips appear for each input as you hover and dwell over each.
  7. Enter some valid values in the fields based on displayed tooltips, then click the "check" button to apply the entered offset.
  8. Verify that the Start time button is updated properly, that Time Conductor ticks and visible telemetry displays as expected.
  9. Repeat steps 4 through 8 for a few different valid values.
  10. Repeat steps 4 through 8, but enter invalid values. Verify that the fields with bad values display in red and the "check" button is disabled and won't allow the popup to be dismissed:
    Screen Shot 2021-01-26 at 4 12 16 PM

@akhenry
Copy link
Contributor

akhenry commented Jun 7, 2021

Closed by #3409

@kobe1104
Copy link
Contributor

Hitting the ESC key doesn't close the popup. Besides that all are working. Testathon 6/22/21.

@charlesh88
Copy link
Contributor

Verified Testathon 06-22-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants