Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plots] Should not make requests every time a user clicks on the plot #3033

Closed
deeptailor opened this issue May 12, 2020 · 3 comments · Fixed by #3036 or #5637
Closed

[Plots] Should not make requests every time a user clicks on the plot #3033

deeptailor opened this issue May 12, 2020 · 3 comments · Fixed by #3036 or #5637

Comments

@deeptailor
Copy link
Contributor

deeptailor commented May 12, 2020

Plots should not be requesting new data every time a user clicks on the plot. It should only re-request when the user uses marquee zoom or pan.

Steps to Reproduce

  1. Use console to set a breakpoint inside of request() in TelemetryAPI.js
  2. Open a plot view
  3. Observe that breakpoint is hit
  4. Resume app
  5. Zoom or pan and observe that breakpoint is hit again
  6. Resume app
  7. click and observe that breakpoint is hit again

Behavior

Expected - Request not called on click (Breakpoint is not hit on click)
Actual - Request is called on click

@davetsay
Copy link
Contributor

davetsay commented May 15, 2020

If I pan (possibly zoom then pan), clicks will request new data. 05/15/2020

@nikhilmandlik
Copy link
Contributor

Able to reproduce using,

  1. Use console to set a breakpoint inside of request() in TelemetryAPI.js
  2. Open a plot view
  3. Observe that breakpoint is hit
  4. Resume app
  5. Zoom and observe that breakpoint is hit again
  6. Pan and observe that breakpoint is hit again
  7. Now every click on plot hits breakpoint

@ozyx
Copy link
Contributor

ozyx commented Sep 30, 2022

Verified Testathon 09/30/22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants