Skip to content

Commit ab01db9

Browse files
committed
last lint fixes
1 parent af95399 commit ab01db9

File tree

2 files changed

+18
-22
lines changed

2 files changed

+18
-22
lines changed

e2e/tests/functional/plugins/notebook/notebookSnapshots.e2e.spec.js

+16-20
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@
2424
This test suite is dedicated to tests which verify the basic operations surrounding Notebooks.
2525
*/
2626

27-
import { createDomainObjectWithDefaults } from '../../../../appActions.js';
2827
import { expect, test } from '../../../../pluginFixtures.js';
2928

30-
const NOTEBOOK_NAME = 'Notebook';
31-
3229
test.describe('Snapshot Menu tests', () => {
3330
test.fixme(
3431
'When no default notebook is selected, Snapshot Menu dropdown should only have a single option',
@@ -90,27 +87,26 @@ test.describe('Snapshot Container tests', () => {
9087
await page.getByRole('menuitem', { name: 'Save to Notebook Snapshots' }).click();
9188
await page.getByLabel('Show Snapshots').click();
9289
});
93-
test.only('A snapshot can be Quick Viewed from Container with 3 dot action menu', async ({
94-
page
95-
}) => {
90+
test('A snapshot can be Quick Viewed from Container with 3 dot action menu', async ({ page }) => {
9691
await page.locator('.c-snapshot.c-ne__embed').first().getByTitle('More actions').click();
9792
await page.getByRole('menuitem', { name: 'Quick View' }).click();
9893
await expect(page.locator('.c-overlay__outer')).toBeVisible();
9994
});
100-
test('A snapshot can be Viewed, Annotated, display deleted, and saved from Container with 3 dot action menu', async ({
101-
page
102-
}) => {
103-
await page.locator('.c-snapshot.c-ne__embed').first().getByTitle('More actions').click();
104-
await page.getByRole('menuitem', { name: ' View Snapshot' }).click();
105-
await expect(page.locator('.c-overlay__outer')).toBeVisible();
106-
await page.getByTitle('Annotate').click();
107-
await expect(page.locator('#snap-annotation-canvas')).toBeVisible();
108-
await page.getByRole('button', { name: '' }).click();
109-
// await expect(page.locator('#snap-annotation-canvas')).not.toBeVisible();
110-
await page.getByRole('button', { name: 'Save' }).click();
111-
await page.getByRole('button', { name: 'Done' }).click();
112-
//await expect(await page.locator)
113-
});
95+
test.fixme(
96+
'A snapshot can be Viewed, Annotated, display deleted, and saved from Container with 3 dot action menu',
97+
async ({ page }) => {
98+
await page.locator('.c-snapshot.c-ne__embed').first().getByTitle('More actions').click();
99+
await page.getByRole('menuitem', { name: ' View Snapshot' }).click();
100+
await expect(page.locator('.c-overlay__outer')).toBeVisible();
101+
await page.getByTitle('Annotate').click();
102+
await expect(page.locator('#snap-annotation-canvas')).toBeVisible();
103+
await page.getByRole('button', { name: '' }).click();
104+
// await expect(page.locator('#snap-annotation-canvas')).not.toBeVisible();
105+
await page.getByRole('button', { name: 'Save' }).click();
106+
await page.getByRole('button', { name: 'Done' }).click();
107+
//await expect(await page.locator)
108+
}
109+
);
114110
test.fixme('5 Snapshots can be added to a container', async ({ page }) => {});
115111
test.fixme(
116112
'5 Snapshots can be added to a container and Deleted with Delete All action',

e2e/tests/visual-a11y/components/header.visual.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Tests the branding associated with the default deployment. At least the about mo
2626

2727
import percySnapshot from '@percy/playwright';
2828

29-
import { scanForA11yViolations, test, expect } from '../../../avpFixtures.js';
29+
import { expect, scanForA11yViolations, test } from '../../../avpFixtures.js';
3030
import { VISUAL_URL } from '../../../constants.js';
3131

3232
//Declare the scope of the visual test
@@ -59,7 +59,7 @@ test.describe('Visual - Header @a11y', () => {
5959
await percySnapshot(page, `Notebook Snapshot Show button (theme: '${theme}')`, {
6060
scope: header
6161
});
62-
expect(await page.getByLabel('Show Snapshots')).toBeVisible();
62+
await expect(await page.getByLabel('Show Snapshots')).toBeVisible();
6363
});
6464
});
6565
test.afterEach(async ({ page }, testInfo) => {

0 commit comments

Comments
 (0)