From 44504feeb9101d5abf947b3c0a60f3577bc0c237 Mon Sep 17 00:00:00 2001 From: Charbel Date: Mon, 22 Aug 2016 15:38:17 -0300 Subject: [PATCH 1/6] [Frontend] Tweak markup --- index.html | 21 ++++---- .../forms/res/templates/controls/color.html | 8 +-- .../res/templates/controls/composite.html | 26 +++++----- platform/forms/res/templates/toolbar.html | 52 +++++++++---------- 4 files changed, 53 insertions(+), 54 deletions(-) diff --git a/index.html b/index.html index e47efe91b5a..fcd37cfb0b3 100644 --- a/index.html +++ b/index.html @@ -19,16 +19,15 @@ this source code distribution or the Licensing information page available at runtime from the About dialog for additional information. --> - - - - + + + + - - - - - - + + + +
diff --git a/platform/forms/res/templates/controls/color.html b/platform/forms/res/templates/controls/color.html index e7e4913341f..c9a4bbdd4ae 100644 --- a/platform/forms/res/templates/controls/color.html +++ b/platform/forms/res/templates/controls/color.html @@ -36,18 +36,18 @@ ng-controller="ColorController as colors" ng-show="toggle.isActive()">
+ class="l-palette-row l-option-row" + ng-if="!structure.mandatory">
None
diff --git a/platform/forms/res/templates/controls/composite.html b/platform/forms/res/templates/controls/composite.html index 1c3559e2fcf..e036617c3c4 100644 --- a/platform/forms/res/templates/controls/composite.html +++ b/platform/forms/res/templates/controls/composite.html @@ -21,18 +21,18 @@ --> -
- - - - {{item.name}} - -
+
+ + + + {{item.name}} + +
diff --git a/platform/forms/res/templates/toolbar.html b/platform/forms/res/templates/toolbar.html index 58923e0314e..f109b670e73 100644 --- a/platform/forms/res/templates/toolbar.html +++ b/platform/forms/res/templates/toolbar.html @@ -20,31 +20,31 @@ at runtime from the About dialog for additional information. -->
-
- - +
+ + - - - - - -
+ + + + + +
\ No newline at end of file From a7f830177a2c67d82024d73b620d524e7f79dee2 Mon Sep 17 00:00:00 2001 From: Derek Webb Date: Mon, 29 Aug 2016 18:33:48 -0400 Subject: [PATCH 2/6] [Context Menu] New Tab button available in edit mode. #843 --- platform/commonUI/edit/bundle.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/commonUI/edit/bundle.js b/platform/commonUI/edit/bundle.js index 2c5a79bda3a..33d92f913ca 100644 --- a/platform/commonUI/edit/bundle.js +++ b/platform/commonUI/edit/bundle.js @@ -387,7 +387,7 @@ define([ "constants": [ { "key": "editModeBlacklist", - "value": ["copy", "follow", "window", "link", "locate"] + "value": ["copy", "follow", "link", "locate"] }, { "key": "nonEditContextBlacklist", From 55603b927f425114c87811e292d5050feb970316 Mon Sep 17 00:00:00 2001 From: Charles Hacskaylo Date: Thu, 1 Sep 2016 19:37:36 -0700 Subject: [PATCH 3/6] [Frontend] Generalized markup and CSS for control-bar Fixes #1166 New markup and CSS MIgrated existing tabular views to use new styles --- .../commonUI/general/res/sass/_views.scss | 40 +++++++++++++++++++ .../general/res/sass/lists/_tabular.scss | 36 ----------------- .../table/res/templates/historical-table.html | 2 +- .../table/res/templates/mct-table.html | 12 +++--- .../table/res/templates/rt-table.html | 2 +- 5 files changed, 49 insertions(+), 43 deletions(-) diff --git a/platform/commonUI/general/res/sass/_views.scss b/platform/commonUI/general/res/sass/_views.scss index 96c78f1dd28..2400d540be1 100644 --- a/platform/commonUI/general/res/sass/_views.scss +++ b/platform/commonUI/general/res/sass/_views.scss @@ -1,4 +1,12 @@ /* Styles for sub-dividing views generically */ +$cbH: 25px; + +.l-control-bar { + // Element that can be placed above l-view-section + height: $cbH; + +} + .l-view-section { @include absPosDefault(0); @@ -15,4 +23,36 @@ .inline-block { display: inline-block; } +} + +.has-control-bar { + .l-view-section { + top: $cbH + $interiorMargin; + } +} + + +.child-frame { + .has-control-bar { + $btnExportH: $btnFrameH; + .l-control-bar { + @include trans-prop-nice(opacity, $dur: 50ms); + opacity: 0; + } + .l-view-section { + @include trans-prop-nice(top, $dur: 150ms, $delay: 50ms); + top: 0; + } + &:hover { + .l-control-bar { + @include trans-prop-nice(opacity, 150ms, 100ms); + opacity: 1; + } + .l-view-section { + @include trans-prop-nice(top, $dur: 150ms); + top: $btnExportH + $interiorMargin; + } + } + } + } \ No newline at end of file diff --git a/platform/commonUI/general/res/sass/lists/_tabular.scss b/platform/commonUI/general/res/sass/lists/_tabular.scss index 5671fe178d0..d68486547ea 100644 --- a/platform/commonUI/general/res/sass/lists/_tabular.scss +++ b/platform/commonUI/general/res/sass/lists/_tabular.scss @@ -160,39 +160,3 @@ table { } } } - -/********************************************************** SPECIFIC TABULAR VIEWS */ -.tabular-holder { - &.t-exportable { - $btnExportH: 25px; - .l-view-section { - top: $btnExportH + $interiorMargin; - } - } -} - -.child-frame { - .tabular-holder { - &.t-exportable { - $btnExportH: $btnFrameH; - .s-button.t-export { - @include trans-prop-nice(opacity, $dur: 50ms); - opacity: 0; - } - .l-view-section { - @include trans-prop-nice(top, $dur: 150ms, $delay: 50ms); - top: 0; - } - &:hover { - .s-button.t-export { - @include trans-prop-nice(opacity, 150ms, 100ms); - opacity: 1; - } - .l-view-section { - @include trans-prop-nice(top, $dur: 150ms); - top: $btnExportH + $interiorMargin; - } - } - } - } -} \ No newline at end of file diff --git a/platform/features/table/res/templates/historical-table.html b/platform/features/table/res/templates/historical-table.html index e2cd91b0dbf..d306601dafb 100644 --- a/platform/features/table/res/templates/historical-table.html +++ b/platform/features/table/res/templates/historical-table.html @@ -4,6 +4,6 @@ rows="rows" enableFilter="true" enableSort="true" - class="tabular-holder t-exportable"> + class="tabular-holder has-control-bar">
\ No newline at end of file diff --git a/platform/features/table/res/templates/mct-table.html b/platform/features/table/res/templates/mct-table.html index 6d96b17afd3..ac06f53e28a 100644 --- a/platform/features/table/res/templates/mct-table.html +++ b/platform/features/table/res/templates/mct-table.html @@ -1,8 +1,10 @@ - - Export - +
+ + Export + +
diff --git a/platform/features/table/res/templates/rt-table.html b/platform/features/table/res/templates/rt-table.html index c6fb0d24229..573eeb89f69 100644 --- a/platform/features/table/res/templates/rt-table.html +++ b/platform/features/table/res/templates/rt-table.html @@ -4,7 +4,7 @@ rows="rows" enableFilter="true" enableSort="true" - class="tabular-holder t-exportable" + class="tabular-holder has-control-bar" auto-scroll="true"> \ No newline at end of file From 39dcb937d5a4eb0029a2b13a6578dca3cdd6651e Mon Sep 17 00:00:00 2001 From: Charles Hacskaylo Date: Thu, 1 Sep 2016 20:09:38 -0700 Subject: [PATCH 4/6] [Frontend] CSS and markup tweaks Fixes #1166 New control-bar height constant Removed font-size definition in .l-view-section --- platform/commonUI/general/res/sass/_constants.scss | 1 + platform/commonUI/general/res/sass/_views.scss | 11 +++-------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/platform/commonUI/general/res/sass/_constants.scss b/platform/commonUI/general/res/sass/_constants.scss index 5550a9019e3..8fb1a39cb14 100644 --- a/platform/commonUI/general/res/sass/_constants.scss +++ b/platform/commonUI/general/res/sass/_constants.scss @@ -126,6 +126,7 @@ $menuLineH: 1.5rem; $menuLineHPx: 24px; $btnStdH: 25px; $btnToolbarH: $btnStdH; +$controlBarH: $btnStdH; $btnFrameH: 16px; /************************** PATHS */ diff --git a/platform/commonUI/general/res/sass/_views.scss b/platform/commonUI/general/res/sass/_views.scss index 2400d540be1..357f9f3c7c4 100644 --- a/platform/commonUI/general/res/sass/_views.scss +++ b/platform/commonUI/general/res/sass/_views.scss @@ -1,16 +1,11 @@ /* Styles for sub-dividing views generically */ -$cbH: 25px; - .l-control-bar { - // Element that can be placed above l-view-section - height: $cbH; - + // Element that can be placed above l-view-section, holds controls, buttons, etc. + height: $controlBarH; } - .l-view-section { @include absPosDefault(0); - font-size: 0.8rem; h2 { color: #fff; margin-bottom: $interiorMargin; @@ -27,7 +22,7 @@ $cbH: 25px; .has-control-bar { .l-view-section { - top: $cbH + $interiorMargin; + top: $controlBarH + $interiorMargin; } } From f7dfccb096748d41c30ac8173812d7fe5db29ac6 Mon Sep 17 00:00:00 2001 From: Victor Woeltjen Date: Thu, 8 Sep 2016 13:41:51 -0700 Subject: [PATCH 5/6] [Build] Depend on phantomjs-prebuilt 2.1.11 ...due to issues installing 2.1.12 on Linux. Fixes #1176. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 491904fe4dc..6d23b86d52e 100644 --- a/package.json +++ b/package.json @@ -40,7 +40,7 @@ "mkdirp": "^0.5.1", "moment": "^2.11.1", "node-bourbon": "^4.2.3", - "phantomjs-prebuilt": "^2.1.0", + "phantomjs-prebuilt": "2.1.11", "requirejs": "2.1.x", "split": "^1.0.0" }, From 32e7f57a7c65bbcf97f13ae769d5eb8ea22f748b Mon Sep 17 00:00:00 2001 From: Victor Woeltjen Date: Thu, 8 Sep 2016 13:48:53 -0700 Subject: [PATCH 6/6] [Build] Accept future phantomjs versions --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 6d23b86d52e..5563f65c82a 100644 --- a/package.json +++ b/package.json @@ -40,7 +40,7 @@ "mkdirp": "^0.5.1", "moment": "^2.11.1", "node-bourbon": "^4.2.3", - "phantomjs-prebuilt": "2.1.11", + "phantomjs-prebuilt": "2.1.11 || >2.1.12 <3.0.0", "requirejs": "2.1.x", "split": "^1.0.0" },