From a2ff411fbf2ad01f80311a606d6a85f525589025 Mon Sep 17 00:00:00 2001 From: Dan Redding <125183946+dangotbanned@users.noreply.github.com> Date: Tue, 4 Feb 2025 15:22:06 +0000 Subject: [PATCH] fix(typing): Use correct `TypeVar`/`Union` pairs in `from_native` (#1935) Resolves 4x `pyright` warnings --- narwhals/translate.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/narwhals/translate.py b/narwhals/translate.py index f370650869..0f6545c3f7 100644 --- a/narwhals/translate.py +++ b/narwhals/translate.py @@ -48,6 +48,7 @@ from narwhals.dataframe import LazyFrame from narwhals.series import Series from narwhals.typing import IntoDataFrameT + from narwhals.typing import IntoFrame from narwhals.typing import IntoFrameT from narwhals.typing import IntoSeries from narwhals.typing import IntoSeriesT @@ -129,7 +130,7 @@ def to_native( @overload def from_native( - native_object: IntoDataFrameT | IntoSeriesT, + native_object: IntoDataFrameT | IntoSeries, *, pass_through: Literal[True], eager_only: Literal[False] = ..., @@ -239,7 +240,7 @@ def from_native( @overload def from_native( - native_object: IntoFrameT | IntoSeriesT, + native_object: IntoFrame | IntoSeries, *, pass_through: Literal[False] = ..., eager_only: Literal[False] = ..., @@ -283,7 +284,7 @@ def from_native( def from_native( - native_object: IntoFrameT | IntoSeries | T, + native_object: IntoFrameT | IntoSeriesT | IntoFrame | IntoSeries | T, *, strict: bool | None = None, pass_through: bool | None = None,