Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when doing a find/replace with \n #20099

Closed
hronro opened this issue Feb 7, 2017 · 3 comments
Closed

Issues when doing a find/replace with \n #20099

hronro opened this issue Feb 7, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@hronro
Copy link

hronro commented Feb 7, 2017

2017-02-07 13_33_34

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Feb 7, 2017
@roblourens
Copy link
Member

You will want to use $ instead of \n. I'm seeing some other strange things though:

If I do a similar search,
feb-07-2017 15-55-50

The error callstack is:

Cannot read property 'replace' of null: TypeError: Cannot read property 'replace' of null
    at Object.escape (file:////Users/roblou/code/vscode/out/vs/base/common/strings.js:59:20)
    at SearchRenderer.renderContents (file:////Users/roblou/code/vscode/out/vs/workbench/parts/search/browser/searchResultsView.js:158:43)
    at SearchRenderer.ActionsRenderer.render (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/actionsRenderer.js:62:42)
    at SearchRenderer.LegacyRenderer.renderElement (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/treeDefaults.js:36:51)
    at ViewItem.render (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/treeView.js:230:39)
    at TreeView.refreshViewItem (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/treeView.js:893:18)
    at TreeView.onRefreshItem (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/treeView.js:883:18)
    at TreeView.HeightMap.onRemoveItems (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/treeViewModel.js:100:22)
    at TreeView.onItemChildrenRefreshed (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/treeView.js:743:34)
    at TreeView.onModelEvents (file:////Users/roblou/code/vscode/out/vs/base/parts/tree/browser/treeView.js:534:30)
Cannot read property 'length' of null: TypeError: Cannot read property 'length' of null
    at SearchViewlet.getSelectionFrom (file:////Users/roblou/code/vscode/out/vs/workbench/parts/search/browser/searchViewlet.js:927:69)
    at SearchViewlet.open (file:////Users/roblou/code/vscode/out/vs/workbench/parts/search/browser/searchViewlet.js:889:34)
    at file:////Users/roblou/code/vscode/out/vs/workbench/parts/search/browser/searchActions.js:500:35
    at CompletePromise_ctor.CompletePromise_then [as then] (file:////Users/roblou/code/vscode/out/vs/base/common/winjs.base.raw.js:1566:49)
    at ReplaceAction.run (file:////Users/roblou/code/vscode/out/vs/workbench/parts/search/browser/searchActions.js:492:64)
    at ActionRunner.run (file:////Users/roblou/code/vscode/out/vs/base/common/actions.js:202:52)
    at ActionItem.BaseActionItem.onClick (file:////Users/roblou/code/vscode/out/vs/base/browser/ui/actionbar/actionbar.js:115:32)
    at file:////Users/roblou/code/vscode/out/vs/base/browser/ui/actionbar/actionbar.js:98:55

@roblourens roblourens changed the title Globle replace didn't work Issues when doing a find/replace with \n Feb 7, 2017
@roblourens roblourens assigned sandy081 and unassigned roblourens Feb 7, 2017
@sandy081
Copy link
Member

sandy081 commented Feb 9, 2017

Firstly, multiline search is not supported yet for Search - See #13155. Issuse mentioned in the description needs multi line support.

Issue mentioned in first comment is also related to multi line search. But it should not break the way it is now and has to be fixed to the current support. I would move that into a separate issue #20311 and fix it.

@sandy081
Copy link
Member

sandy081 commented Feb 9, 2017

Duplicates #13155

@sandy081 sandy081 closed this as completed Feb 9, 2017
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants