Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing meta data when upgrading from 4.3.0 to 5.0.1 #139

Open
MM3y3r opened this issue Jun 18, 2020 · 2 comments
Open

Missing meta data when upgrading from 4.3.0 to 5.0.1 #139

MM3y3r opened this issue Jun 18, 2020 · 2 comments

Comments

@MM3y3r
Copy link

MM3y3r commented Jun 18, 2020

garmeeh/next-seo#383
garmeeh/next-seo#383 (comment)

Just wanted to let you know, that we had a major outage in production yesterday due an upgrade from 4.3.0 to 5.0.1. All our meta data went missing and instead defaulted to the fallback meta data. That resulted in assets becoming un-sharable as no crawlers could see the meta data anymore. Also SEO was a mess. We are not sure what EXACTLY the root cause was, but it seems some functionality may not be backwards compatible.

Thank you for your work on this library. Using it has worked very well up until now. With the rollback it is also working fine again.

@MM3y3r MM3y3r changed the title Missing meta data when upgrading from 4.3.0 to 5.0.1 leading to outage Missing meta data when upgrading from 4.3.0 to 5.0.1 Jun 18, 2020
@chemicalkosek
Copy link

Since 5.0.0 '@apollo/react-ssr' is not included. You need to import getDataFromTree and pass it. From the readme:

import { getDataFromTree } from '@apollo/react-ssr';

export default withApollo(Index, { getDataFromTree });

@MM3y3r
Copy link
Author

MM3y3r commented Jun 19, 2020

We are currently testing your suggestion. Will let you know whether that fixed it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants