Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: description issue? #30148

Open
2 tasks done
woodliu opened this issue Mar 7, 2025 · 1 comment
Open
2 tasks done

DOC: description issue? #30148

woodliu opened this issue Mar 7, 2025 · 1 comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder

Comments

@woodliu
Copy link

woodliu commented Mar 7, 2025

URL

https://github.com/langchain-ai/langchain/blob/master/docs/docs/concepts/chat_history.mdx

Checklist

  • I added a very descriptive title to this issue.
  • I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:

There is a description about the chat historyas:
The last message should be either a "user" message or a "tool" message containing the result of a tool call.
Isn't it should be
The last message should be either a "assistant" message or a "tool" message containing the result of a tool call.
according to the picture: https://python.langchain.com/docs/concepts/chat_history/#conversation-patterns

Idea or request for content:

No response

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Mar 7, 2025
@YassinNouh21
Copy link

@woodliu I think it should be like this

- The conversation should follow one of these structures:
    - The first message is either a "user" message or a "system" message, followed by a "user" and then an "assistant" message.
    - When sending messages to a chat model for inference, the last message should be either a "user" message or a "tool" message containing the result of a tool call.
    - In a complete conversation, the final message would typically be an "assistant" message (the model's response).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
Projects
None yet
Development

No branches or pull requests

2 participants