Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clips copied from other project cannot be exported to tools. #1174

Open
stingpie opened this issue Dec 20, 2024 · 1 comment
Open

clips copied from other project cannot be exported to tools. #1174

stingpie opened this issue Dec 20, 2024 · 1 comment
Labels

Comments

@stingpie
Copy link

Please include the following information.

  1. Flowblade version (Help->About): 2.16.3
  2. MLT version (Help->Runtime Environment): 7.28.0
  3. Your distribution and desktop environment(Ubuntu/Unity, Debian/KDE, Mint/Cinnamon etc.): arch
  4. X11 or Wayland: x11
  5. If possible, try to provide step-by-step instructions on how to reproduce the issue. From developer point of view this is the easieast way to understand what is happening.:
    create two projects, with different media files. cut a clip out of the second project, and copy it into the first one. Right click on the clip, select export to tool>reverser. Nothing will happen. In the terminal, python will throw an exception:

Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/Flowblade/toolsintegration.py", line 70, in export_callback
new_instance.do_export()
File "/usr/lib/python3.12/site-packages/Flowblade/toolsintegration.py", line 134, in do_export
media_file.mark_in = clip.clip_in
^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'mark_in'

@jliljebl
Copy link
Owner

create two projects, with different media files. cut a clip out of the second project, and copy it into the first one. Right click on the clip, select export to tool>reverser. Nothing will happen. In the terminal, python will throw an exception:

For 2.18 we replaced export to tool>reverse functionality with direct timeline rendering, slowmo/reverse clips are rendered directly onto timeline without being opened in a tool and creating new Media Items and that seems to work.

Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/Flowblade/toolsintegration.py", line 70, in export_callback
new_instance.do_export()
File "/usr/lib/python3.12/site-packages/Flowblade/toolsintegration.py", line 134, in do_export
media_file.mark_in = clip.clip_in
^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'mark_in'

I'll still need to try to fix this issue because we need to have imported Media Items be indistinguishable from Media Items created in project so that we don't hit any issues like you describe here, even if this seems to be working with new Timeline slow motion/reverse clips.

I'll add back the possibility to open clip in G'Mic tool to test this. Maybe that really was a useful feature that got dropped for 2.18 with too little consideration given.

@jliljebl jliljebl added the bug label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants