Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to have firmware update prompt appear multiple times on connect #299

Open
intvsteve opened this issue Mar 6, 2019 · 1 comment
Assignees
Labels

Comments

@intvsteve
Copy link
Owner

Operating system version

All

Program version (from About box)

1.0.0.4499

Expected behavior

Prompt to update firmware only happens once each time cart is connected to UI.

Actual behavior

Prompt to update firmware appears more than once when cart is connected.

Steps to reproduce

  1. Have cart with old firmware (prior to 4416)
  2. Connect to computer while latest UI is running

Crash log if available (paste or attach)

N/A

@intvsteve
Copy link
Owner Author

Only saw this once, and was running a horribly slow VM on a heavily taxed system. The theory of this is follows:

The 'heartbeat' timer ticks and sees that the pending 'check for update'. task needs running. The way this is implemented is via a BeginInvoke over to the UI thread.

HOWEVER because it's done this way, if the UI thread is blocked, then wakes up, shows a dialog, and starts processing these 'being invoked' tasks under the dialog, they can nest.

Need to prevent this from happening.

@intvsteve intvsteve self-assigned this Mar 6, 2019
@intvsteve intvsteve added the bug label Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant