Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure 2-Graphcoloring #274

Open
chengquan50 opened this issue Feb 12, 2025 · 3 comments
Open

Figure 2-Graphcoloring #274

chengquan50 opened this issue Feb 12, 2025 · 3 comments

Comments

@chengquan50
Copy link

The reward of the graphcoloring environment is an integer, and the convergent mean generated by the three random seeds needs to be divisible by 3, but 3 times the convergent mean given in the graph is obviously not an integer.

@sash-a
Copy link
Collaborator

sash-a commented Feb 12, 2025

Hi @chengquan50 👋

Not sure why the mean reward over 3 random seeds should be divisible by 3? The reward is simply -num_colours_used which may or may not be divisible by 3

@chengquan50
Copy link
Author

My concern is that since reward is an integer in this environment, according to the legend, "Experiments were run with three different seeds, with the median represented as a blue curve and the min/max as the shaded region.", the blue curve should also be an integer, right? Thanks

@sash-a
Copy link
Collaborator

sash-a commented Feb 17, 2025

I see, it's possible that it was mean instead of median in this case by mistake, but I'm not sure. Maybe @clement-bonnet or @surana01 or @coyettev can give you a better answer as they worked on the graphs in the paper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants