Dash supports more plist keys: DashDocSetFallbackURL & isJavaScriptEnabled #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s ask @Kapeli ✨! :) |
|
Looks good.
It's for all JavaScript files, regardless if they're bundled or remote. |
|
In that case all it needs it docs. :) (don’t forget authors.rst & changelog.rst) |
…abled This PR adds support for both based on the information provided in https://kapeli.com/docsets#improveDocset
reaperhulk
force-pushed
the
support-new-plist-keys
branch
from
3f9844c to
5fc005e
Compare
| @@ -11,6 +11,7 @@ Changelog | |||
| The move from ``unicode_literals`` to explicit prefixes broke some things that are fixed now. | |||
| (`#29 <https://github.com/hynek/doc2dash/issues/29>`_, `#30 <https://github.com/hynek/doc2dash/issues/30>`_) | |||
| - Fix detection of `pydoctor 0.5 <http://bazaar.launchpad.net/~mwhudson/pydoctor/dev/revision/605>`_. (`#31 <https://github.com/hynek/doc2dash/issues/31>`_) | |||
| - Add support for ``--enable-js`` and ``-online-redirect-url`` options. See :doc:`/usage` for more information. | |||
hynek
added a commit
that referenced
this pull request
Oct 11, 2015
Dash supports more plist keys: DashDocSetFallbackURL & isJavaScriptEnabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for both based on the information provided in https://kapeli.com/docsets#improveDocset
I'm not sure if I've tested this effectively so let me know what you'd like improved hynek :)
Also, the description for
isJavaScriptEnabled(https://kapeli.com/docsets#enableJavascript) is really not very good. It seems like you need it to beTrueto use bundled JS assets, not actual remote ones?