Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot maximum size is arbitrary and not mentioned in the spec #457

Open
appgurueu opened this issue Aug 8, 2022 · 2 comments
Open

Comments

@appgurueu
Copy link

The validator currently requires screenshots to have a maximum size of 1600x900. This is however not mentioned in the specification at all. Is there any reason for this arbitrary limitation?

@ximion
Copy link
Collaborator

ximion commented Aug 8, 2022

Does using validate-relax help in this case?
You should be validating with appstreamcli for your own project, and we are actually working on moving Flathub to that too, so this will no longer be an issue in future (and tagging screenshots by display dimensions will probably be the future thing we do: ximion/appstream#410)

@CendioOssman
Copy link

This seems to be a wider problem than just the screenshot dimensions. Many of the checks are seemingly arbitrary¹, and there are even things the specification suggests that aren't checked (<provides>):

https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps

From my perspective, the issue seems to be that no one is updating the specification with what is considered best practices.

It would be nice as an application developer to have some documentation of what's expected, and not just run a tool and just blindly follow whatever it tells me.

¹ They seem to try to follow Flathub's requirements, which are undocumented as far as I can tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants