Do not append missing XML declaration in formatted responses

[BoboTiG]

Minimal reproduction code and steps

1. Create the file repro.xml with that content:

<!-- comment --><root><element key='value'>text</element><element>text</element>tail<empty-element/></root>

2. Serve that file using:

$ python -m http.server

3. And GET the file:

$ http :8000/repro.xml

Current result

<?xml version="1.0" encoding="utf-8"?>
<!-- comment -->
<root>
  <element key="value">text</element>
  <element>text</element>
  tail
  <empty-element/>
</root>

Note the additional XML declaration (it is not present from the original response).

Expected result

The responses should not be altered:

<!-- comment -->
<root>
  <element key="value">text</element>
  <element>text</element>
  tail
  <empty-element/>
</root>

---

Additional information, screenshots, or code examples

When pretty-printing a XML response that does not contain a XML declaration, minidom will append one (source).

[this-is-r-gaurav]

Hi @BoboTiG can i raise a PR for that fix?

[BoboTiG]

Of course @this-is-r-gaurav 👍 :)

[this-is-r-gaurav]

Its a dirty hack, not sure whether its acceptable, if any further suggestion i can update it @BoboTiG #1183

[this-is-r-gaurav]

Two test cases are failing after this PR:

• tests/test_xml.py::test_valid_xml[file3]
  • raw_file: simple_raw.xml
  • formatted_file: simple_formatted.xml
• tests/test_xml.py::test_valid_xml[file0]
  • raw_file simple-ns_raw.xml
  • formatted_file: simple-ns_formatted.xml

I think after this fix formatted file will need to remove xml prolog. If i need to fix those test, do let me know please. :)

[BoboTiG]

I think after this fix formatted file will need to remove xml prolog. If i need to fix those test, do let me know please. :)

Indeed, simply removing the XML declaration is needed, let's do that in the same PR :)

[this-is-r-gaurav]

Thanks @BoboTiG , learned new things today. I have updated the fixture files as well as logic.