fix: error formatting, #1319 #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acao
changed the title
yoshiakis
added a commit
to yoshiakis/graphiql
that referenced
this pull request
Feb 28, 2020
print to stderr even if falsy value is thrown or thrown error does not have property `stack`. it was intended to implement by graphql#1381
acao
pushed a commit
that referenced
this pull request
Feb 29, 2020
print to stderr even if falsy value is thrown or thrown error does not have property `stack`. it was intended to implement by #1381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1319 by @yoshiakis
re-creates the already reviewed #1320 which for some reason is having a yarn.lock issue