Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the changes for the Helm chart revert #1232

Closed
grcevski opened this issue Oct 7, 2024 · 2 comments
Closed

Bring back the changes for the Helm chart revert #1232

grcevski opened this issue Oct 7, 2024 · 2 comments

Comments

@grcevski
Copy link
Contributor

grcevski commented Oct 7, 2024

We should re-instate the changes for #1184.

Also we need to add Helm tests to avoid this breakage in the future.

Relates to #1229

@mariomac
Copy link
Contributor

mariomac commented Oct 7, 2024

The original issue was actually a problem in how Beyla treated the filter attributes: Beyla returned error because the client attribute of the filter was not recognized as an attribute in RED metrics, but the clientattribute is already present in some application metrics such as service graph metrics.

@marctc marctc added the bug label Oct 11, 2024
@marctc marctc removed the bug label Nov 22, 2024
@marctc
Copy link
Contributor

marctc commented Nov 25, 2024

I believe this is already fix. Reopen is that not the case.

@marctc marctc closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants