Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purging caches deselects filter lists #1429

Closed
ghost opened this issue Feb 26, 2016 · 4 comments
Closed

Purging caches deselects filter lists #1429

ghost opened this issue Feb 26, 2016 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 26, 2016

Describe the issue

Selecting a filter list and then clicking Purge all caches removes the check mark from said filter list.

Screenshot in which the issue can be seen

https://zippy.gfycat.com/BleakSorrowfulAmazontreeboa.webm

Steps for anyone to reproduce the issue

  1. Open the 3rd-party filters tab in uBO's dashboard.
  2. Select a filter list.
  3. Click Purge all caches.

Your settings

  • Browser/version: Firefox 44.0.2
  • uBlock Origin version: 1.6.2
@lewisje
Copy link

lewisje commented Feb 27, 2016

I think this only happens if you didn't select "Apply Changes" first, and it's similar to what happens if you select a list and then click the Update button without first clicking the Apply button; it is annoying, but I had just thought it was intentional.

@gorhill
Copy link
Owner

gorhill commented Feb 27, 2016

similar to what happens if you select a list and then click the Update button without first clicking the Apply button

This one was fixed a long while ago.

@ghost
Copy link
Author

ghost commented Mar 6, 2016

Same problem:

  1. Open the 3rd-party filters tab in uBO's dashboard.
  2. Select a filter list.
  3. Add a custom filter URL in the text box and click Apply underneath.

Result: The filter list selected in step 2 is deselected again.

@gorhill
Copy link
Owner

gorhill commented Jan 19, 2017

Appears to have been solved in 1.10.5b11, quite probably when I implemented incremental rendering in #2314.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants