Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Revive discussion on https://github.com/golang/go/issues/5901 #36206

Closed
harrisonhjones opened this issue Dec 18, 2019 · 1 comment

Comments

@harrisonhjones
Copy link

I was recommended on the gopher slack to open a proposal for this.

I'd like to reopen discussion of this issue #5901 that @rsc opened July 17, 2013 titled encoding/json: allow override type marshaling. I have a use-case for being able to override the marshalers encoding/json uses. Some other 3p JSON encoders have something similar to what Russ proposed but none, that I can find, work as well, in theory, to what he proposed.

I've updated the comment thread on the original issue so we can continue the discussion over there, or over here. As mentioned: if we can land on a design people are happy with I'm happy to put in the work to write the code & tests.

While it would be backwards compatible we could also consider putting the new code in a different package. Perhaps golang.org/x/encoding/json? like golang.org/x/image/draw did? I'm flexible.

@gopherbot gopherbot added this to the Proposal milestone Dec 18, 2019
@dsnet
Copy link
Member

dsnet commented Dec 18, 2019

Thanks for posting this. I'm going to close this to keep discussion on #5901.

@dsnet dsnet closed this as completed Dec 18, 2019
@golang golang locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants