Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100mb test/benchinput.md file is included in published rubygem #99

Closed
andrew opened this issue Apr 14, 2019 · 3 comments
Closed

100mb test/benchinput.md file is included in published rubygem #99

andrew opened this issue Apr 14, 2019 · 3 comments

Comments

@andrew
Copy link

andrew commented Apr 14, 2019

I was experimenting with vendoring some rubygems into a git repository and ran into a problem when trying to push to GitHub:

remote: error: File commonmarker/test/benchinput.md is 105.52 MB; this exceeds GitHub's file size limit of 100.00 MB

Turns out that https://github.com/gjtorikian/commonmarker/blob/master/commonmarker.gemspec#L21 includes all files in the test directory when publishing, including ones that are ignored by .gitignore, that also includes test/progit which is about 25mb.

So excluding those test from the gemspec should significantly reduce the size of the published gem.

@kivikakk
Copy link
Collaborator

Hm, is this right? It looks like the current gem version is at 146 KB, and has been around there for a long while, with a jump up to 1mb back in Dec 2017 when we did include some extra bits by mistake. Unless you're pulling 0.13.0 from late 2016? There was a 41mb gem by mistake, for sure.

@kivikakk
Copy link
Collaborator

(But thanks for pointing this out -- I'll make the adjustment to the gemspec.)

@andrew
Copy link
Author

andrew commented Apr 15, 2019

Thanks! My experiment was vendoring every version of each gem that Octobox depends on, hence the old versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants