Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for v0.29.0.gfm.7 don't mention new cmark_init_standard_node_flags() function #303

Closed
pyrmont opened this issue Jan 24, 2023 · 3 comments · Fixed by #305
Closed

Comments

@pyrmont
Copy link

pyrmont commented Jan 24, 2023

As a result of 420c20a, v0.29.0.gfm.7 requires cmark library clients to call cmark_init_standard_node_flags(). If this is not done, the assertion below will fail.

assert(node->flags & CMARK_NODE__OPEN);

It would be helpful for clients if the release notes were updated to mention this.

@anticomputer
Copy link

Thanks for the note @pyrmont, we've updated the release notes to mention the new node state management initialization.

@pyrmont
Copy link
Author

pyrmont commented Jan 24, 2023

Thanks!

@kevinbackhouse
Copy link

Apologies! This was my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants