Fix tagging of docker images when releasing fleet #26988
Labels
bug
Something isn't working as documented
#g-orchestration
Orchestration product group
:release
Ready to write code. Scheduled in a release. See "Making changes" in handbook.
💥 Actual behavior
When releasing fleet, the scripts always tag
fleetdm/fleet:latest
.This breaks when releasing patches to older minor versions.
E.g.
fleetdm/fleet:latest
is nowfleetdm/fleet:v4.64.0
.fleetdm/fleet:latest
is nowfleetdm/fleet:v4.63.1
.Which means customers/users using
fleetdm/fleet:latest
experience a downgrade (with e.g. DB migrations issues).Link to reports from the community:
🕯️ More info (optional)
We should only tag
latest
if the version that is being released is the highest.Seems the issue is here:
fleet/.goreleaser.yml
Line 122 in 6886365
Possible solution:
fleetdm/fleet:latest
from.goreleaser.yml
fleetdm/fleet:latest
only when the version being released is the highest. (We need this manual step to be executed as thefleetreleaser
user in Docker hub to not have the email of the person releasing as the "author" of the tagging).The text was updated successfully, but these errors were encountered: