Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tagging of docker images when releasing fleet #26988

Open
lucasmrod opened this issue Mar 10, 2025 · 1 comment
Open

Fix tagging of docker images when releasing fleet #26988

lucasmrod opened this issue Mar 10, 2025 · 1 comment
Labels
bug Something isn't working as documented #g-orchestration Orchestration product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.

Comments

@lucasmrod
Copy link
Member

lucasmrod commented Mar 10, 2025

💥  Actual behavior

When releasing fleet, the scripts always tag fleetdm/fleet:latest.
This breaks when releasing patches to older minor versions.

E.g.

  1. Fleet releases 4.64.0, so fleetdm/fleet:latest is now fleetdm/fleet:v4.64.0.
  2. Fleet releases a patch to minor version 63, e.g. 4.63.1, so fleetdm/fleet:latest is now fleetdm/fleet:v4.63.1.

Which means customers/users using fleetdm/fleet:latest experience a downgrade (with e.g. DB migrations issues).

Link to reports from the community:

🕯️ More info (optional)

We should only tag latest if the version that is being released is the highest.

Seems the issue is here:

- 'fleetdm/fleet:latest'

Possible solution:

  • Remove fleetdm/fleet:latest from .goreleaser.yml
  • Add some condition to the script to do the tagging of fleetdm/fleet:latest only when the version being released is the highest. (We need this manual step to be executed as the fleetreleaser user in Docker hub to not have the email of the person releasing as the "author" of the tagging).
@lucasmrod lucasmrod added :incoming New issue in triage process. :reproduce Involves documenting reproduction steps in the issue bug Something isn't working as documented #g-orchestration Orchestration product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. labels Mar 10, 2025
@lucasmrod
Copy link
Member Author

@lukeheath @georgekarrv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-orchestration Orchestration product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Projects
None yet
Development

No branches or pull requests

1 participant