Clippy nightly fails

[dleifeld]

error: unexpected cfg condition name: test
--> hdbconnect_impl/src/conn/authentication/scram_sha256.rs:84:7
|
84 | #[cfg(test)]
| ^^^^
|
= help: expected names are: clippy, debug_assertions, doc, docsrs, doctest, feature, fmt_debug, miri, overflow_checks, panic, proc_macro, relocatio n_model, rustfmt, sanitize, sanitizer_cfi_generalize_pointers, sanitizer_cfi_normalize_integers, target_abi, target_arch, target_endian, target_env, target _family, target_feature, target_has_atomic, target_has_atomic_equal_alignment, target_has_atomic_load_store, target_os, target_pointer_width, target_thread_loc al, target_vendor, ub_checks, unix, and windows
= help: consider using a Cargo feature instead
= help: or consider adding in Cargo.toml the check-cfg lint config for the lint:
[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(test)'] }
= help: or consider adding println!("cargo::rustc-check-cfg=cfg(test)"); to the top of the build.rs
= note: see https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html for more information about checking conditional configuration
= note: -D unexpected-cfgs implied by -D warnings
= help: to override -D warnings add #[allow(unexpected_cfgs)]

[emabee]

Hm, looks like a bug in clippy nightly. I can't reproduce it, maybe it is fixed already?
#[cfg(test)] is a very old standard way of marking code as test-only.

[dleifeld]

This succeeds in terminal:

cargo +nightly clippy --all-targets --package hdbconnect --all-features -- -D warnings

but fails with run_command!(
So not blocking release

[emabee]

That's weird! I can reproduce this, and thus opened issue 14045 for clippy.

And you're right - this should not block us from releasing a new version!

I provided a proposal how to deal with semver versions in this project. If you agree, I'd suggest you push and publish :-)

[emabee]

Thanks to the help we received in issue 14045 for clippy I could add a workaround to the qualification script. It should be working again as usual.