Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NuGet MSBuild SDK import in solution metaproj #5832

Open
zivkan opened this issue Oct 23, 2020 · 0 comments
Open

Allow NuGet MSBuild SDK import in solution metaproj #5832

zivkan opened this issue Oct 23, 2020 · 0 comments
Labels
Area: Solution (.sln) Issues related to parsing .sln files or building solutions For consideration Used for items on the backlog to raise them to the top of that list for discussion Partner request triaged

Comments

@zivkan
Copy link
Member

zivkan commented Oct 23, 2020

Background

Since 15.0, NuGet restore has been integrated into MSBuild. The way it works is that NuGet.targets is imported by default, which defined the Restore target. There's more to it than that, but that's all that's relevant for this request. This happens not only for projects, but also the solution metaproj, allowing restore to run on the solution, not just on projects individually.

Use case

NuGet would like the ability to ship experimental features out-of-band and iterate more quickly than waiting for VS/.NET SDK shipping cycles. We can do this today for individual project restores using a MSBuild SDK, that causes NuGet.targets to be loaded from the package instead of from MSBuild's default location. I'm looking for a solution for solution restore.

Feature request/repro

I'd like to be able to have a Directory.Solution.props or Directory.Solution.targets with <Sdk Name="NuGet.Experimental.Feature.Sdk" Version="0.0.1" />, so that a dotnet restore my.sln will load the props/targets from my package in the solution metaproj.

Actual

If I try this today, the <Sdk element seems to be silently ignored. It doesn't import anything, but also no error.

@rainersigwald rainersigwald added For consideration Used for items on the backlog to raise them to the top of that list for discussion Partner request Area: Solution (.sln) Issues related to parsing .sln files or building solutions labels Oct 26, 2020
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Solution (.sln) Issues related to parsing .sln files or building solutions For consideration Used for items on the backlog to raise them to the top of that list for discussion Partner request triaged
Projects
None yet
Development

No branches or pull requests

3 participants