If event with payment is deleted, payment is not removed

[sklirg]

What kind of an issue is this?

• Bug report

What is the expected behaviour?

That the payment relation is removed too. Appropriate actions should be taken as well, i.e. refunding already paid relations and such.

What is the current behaviour?

The payment is still there, possibly causing marks to be handed out. Also, the payment toString-method crashes since it depends on the object it was connected to.

How do you reproduce this problem?

• Create an attendance event
• Create payment for the event
• Delete the event
• Payment is still there.

[sklirg]

https://sentry.io/dotkom/onlineweb-4/issues/402671323/

[sklirg]

https://sentry.io/dotkom/onlineweb-4/issues/395248086/

[oleast]

This case is not particularly easy to handle by deleting payments.

If someone has paid for an event we want to keep the information about the payments, even if the payments are refunded and the event is deleted. A refunded payment is still a payment, and it should be stored and kept for accounting purposes. This will be even more important when the Fiken integration is finished #2293

To that end, I would rather say that it should be impossible to delete events with an attached payment. Or at the very least if anyone has attended or paid.
The event should somehow be canceled to make up for that, where every attendee is refunded upon cancelation and the event is marked as hidden visible=False.